Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS developer menu documentation #2315

Merged
merged 16 commits into from
Oct 26, 2020
Merged

Conversation

eeatonaws
Copy link
Contributor

Issue #, if available: N/A

Description of changes: Adds documentation for the iOS developer menu to the Amplify iOS library page.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eeatonaws eeatonaws requested review from drochetti and royjit August 27, 2020 16:17
@eeatonaws eeatonaws marked this pull request as draft August 27, 2020 16:18
@eeatonaws eeatonaws marked this pull request as ready for review August 27, 2020 18:00
Copy link
Contributor

@royjit royjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeatonaws eeatonaws added the amplify/ios Mostly related to iOS software. label Aug 31, 2020
@mauerbac
Copy link
Member

@jpignata @royjit - is this still pending release ?

@sebsto
Copy link
Contributor

sebsto commented Oct 24, 2020

Now that Dev Menu has been released in iOS libs 1.4.0 can we release the doc too ?

@mauerbac
Copy link
Member

@jpignata can we deploy?

@jpignata
Copy link
Contributor

@mauerbac Looks like it has approval from the team. @drochetti Any objections?

@drochetti drochetti merged commit 7383683 into master Oct 26, 2020
@drochetti
Copy link
Contributor

@mauerbac Looks like it has approval from the team. @drochetti Any objections?

@jpignata no objections, I just merged. I'll have to follow up with changes since Apple launched a new App lifecycle which isn't covered in the docs yet, but requires some testing to come up with the right docs.

@drochetti drochetti deleted the eeatonaws-dev-menu-ios-docs branch October 26, 2020 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/ios Mostly related to iOS software.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants