Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Document Combine support for iOS #2198

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Conversation

palpatim
Copy link
Member

@palpatim palpatim commented Aug 6, 2020

NOTE: THIS MUST NOT BE MERGED UNTIL iOS 1.1.0 IS RELEASED

This PR adds documentation for the soon-to-be-released Combine support in iOS.

It adds two major structural changes:

  • It adds a "Using Combine with Amplify" section to the Project Setup tab for iOS. This subsection does not appear for Android or JS
  • It separates Amplify API code samples into "Listener (iOS 11+)" and "Combine (iOS 13+)" sections. This should allow customers easy access to both styles, since it's fully plausible that a customer may wish to mix & match styles in the same project

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@palpatim palpatim requested review from drochetti, harrysolovay and a team August 6, 2020 01:41
@harrysolovay
Copy link
Contributor

@palpatim in the future, in the case that a given PR should not be merged until a condition is met (in this case the release of 1.10), please submit the PR in draft mode.

@palpatim
Copy link
Member Author

palpatim commented Aug 12, 2020

1.1 is released. This PR is now pending @drochetti review.

Copy link
Contributor

@drochetti drochetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was massive! Thanks 👍👍
I scanned all code snippets just looking for major mistakes but didn't find any.

I'll keep my eyes open for customer feedback once we announce it and will fix any problems if needed.

@palpatim palpatim merged commit 6072d4a into master Aug 12, 2020
@palpatim palpatim deleted the palpatim/combine-ios branch August 12, 2020 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants