Skip to content

Conversation

@jakerockland
Copy link
Contributor

Add syntax highlighting support in Github Markdown for Swift, Objective-C, and Info.plist XML. Also changed numbering to increment in Markdown so that numbering is consistent with list items containing code-blocks.

Add syntax highlighting support in Github Markdown for Swift, Objective-C, and Info.plist XML. Also changed numbering to increment in Markdown so that numbering is consistent with list items containing code-blocks.
$ pod setup

1. In your project directory (the directory where your `*.xcodeproj` file is), create a plain text file named `Podfile` (without any file extension) and add the lines below. Replace `YourTarget` with your actual target name.
2. In your project directory (the directory where your `*.xcodeproj` file is), create a plain text file named `Podfile` (without any file extension) and add the lines below. Replace `YourTarget` with your actual target name.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled your changes and opened the README.md in the MacDown viewer. Still, the numbered lists aren't correct. It shows (1) instead of (2). Can you check this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kvasukib, I'm a bit confused. In MacDown viewer on my computer, things seem to be rendered as expected, with the numbering showing (2) in the correct place. I've attached an image here for reference. Is this not what you are seeing or is this numbering just not as expected?

screen shot 2017-12-26 at 3 38 24 pm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check the numbering under "Getting Started with Swift" and "Getting Started with Objective-C" section? Attached the screenshot here.
screenshot_readme

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah @kvasukib I see now, my apologies. I believe I've fixed this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @jakerockland for fixing it. I have pulled the latest changes. Working on it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! @kvasukib 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We did a release. But we have a merge conflict. If you can fix it, I can merge your PR. Thanks!

@rubyrose-alexis rubyrose-alexis merged commit 8be8d5d into aws-amplify:master Jan 19, 2018
@rubyrose-alexis
Copy link
Contributor

Thanks, @jakerockland for the quick reply. Merged.

maheshm2023 pushed a commit to Vonage/aws-sdk-ios that referenced this pull request May 29, 2025
Update README to support syntax highlighting
maheshm2023 pushed a commit to Vonage/aws-sdk-ios that referenced this pull request May 29, 2025
Update README to support syntax highlighting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants