Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding developer preview banner for primitive pages #751

Merged
merged 3 commits into from
Nov 17, 2021
Merged

Conversation

dbanksdesign
Copy link
Contributor

@dbanksdesign dbanksdesign commented Nov 17, 2021

Issue #, if available:

Description of changes: Adding a developer preview banner on primitive pages. Note: with the #741 the alert will look nicer

CleanShot 2021-11-17 at 10 31 51@2x

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

import { SecondaryNav } from './SecondaryNav';
import { TableOfContents } from '../TableOfContents';
import { Footer } from './Footer';

const PrimitiveAlert = () => {
const { tokens } = useTheme();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 18:42 Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 18:42 Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 18:42 Inactive
Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are typos I guess but none blocking

@ErikCH
Copy link
Contributor

ErikCH commented Nov 17, 2021

It might be good, maybe in a separate PR, to add the banner to the Theming page too.

Co-authored-by: Chenwei Zhang <40295569+zchenwei@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Nov 17, 2021

⚠️ No Changeset found

Latest commit: f680691

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Co-authored-by: Chenwei Zhang <40295569+zchenwei@users.noreply.github.com>
Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 19:02 Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 19:02 Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 19:02 Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci November 17, 2021 19:18 Inactive
@dbanksdesign dbanksdesign merged commit 73f266c into main Nov 17, 2021
@dbanksdesign dbanksdesign deleted the preview-alert branch November 17, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants