-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding developer preview banner for primitive pages #751
Conversation
import { SecondaryNav } from './SecondaryNav'; | ||
import { TableOfContents } from '../TableOfContents'; | ||
import { Footer } from './Footer'; | ||
|
||
const PrimitiveAlert = () => { | ||
const { tokens } = useTheme(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! There are typos I guess but none blocking
It might be good, maybe in a separate PR, to add the banner to the Theming page too. |
Co-authored-by: Chenwei Zhang <40295569+zchenwei@users.noreply.github.com>
|
Co-authored-by: Chenwei Zhang <40295569+zchenwei@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue #, if available:
Description of changes: Adding a developer preview banner on primitive pages. Note: with the #741 the alert will look nicer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.