-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Confirm Sign Up tests #606
Conversation
If an error happens in either part of the call, it bubbles up to the UI.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikCH I've made a small change for Vue, but I'm noticing that Cypress is having issues typing into the Confirmation Code
field. Can you help debug these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wlee221 I'm seeing similar issues as Vue when I run the e2e tests – typing into the Confirmation Code
field doesn't seem to work:
@ericclemmons Ah, I think I know what the problem is!
- cy.findByLabelText('Confirmation Code').type('invalidcode');
+ cy.findInputField('Confirmation Code').type('invalidcode'); which searches for accessible textbox instead of the label.
I think we should make |
@wlee221 I attempted that change locally, but it didn't seem to resolve it. I agree, the |
Sync amplify-ui to amplify-ui-staging
Issue #, if available: Fixes #569
Description of changes:
confirm-sign-up.feature
tests to run against@angular @react @vue
I mock {string} with fixture {string}
behaviorwindow.Amplify.*
for the new behaviorBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.