Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): making checkbox icon checked optional #4255

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

dbanksdesign
Copy link
Contributor

@dbanksdesign dbanksdesign commented Jul 17, 2023

Description of changes

Part of the checkbox theme was not passing Output generic, making the design tokens underneath required. This fixes that.

Issue #, if available

Description of how you validated changes

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dbanksdesign dbanksdesign requested a review from a team as a code owner July 17, 2023 21:32
@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2023

⚠️ No Changeset found

Latest commit: 80823d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dbanksdesign dbanksdesign temporarily deployed to ci July 17, 2023 21:51 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 17, 2023 21:51 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 17, 2023 21:51 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 17, 2023 21:51 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 17, 2023 21:51 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign enabled auto-merge (squash) July 17, 2023 22:23
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign temporarily deployed to ci July 18, 2023 15:23 — with GitHub Actions Inactive
@dbanksdesign dbanksdesign merged commit f2ff87f into main Jul 18, 2023
@dbanksdesign dbanksdesign deleted the checkbox-theme-fix branch July 18, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants