refactor(vue): refactor Authenticator #4246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove dependency on mock facade * Update comment * Remove //@ts-ignore * useAuthenticatorValue cleanup * Update packages/vue/src/composables/useAuth.ts * Update packages/vue/src/composables/useAuth.ts * Update packages/vue/src/composables/useAuth.ts * Update tests * fix typo * Update packages/vue/src/composables/__tests__/useAuthenticator.spec.ts
* sign in refactor * sign-in tests * Federated Sign In tests * FederatedSignInButton refactor * Bump jest threshold * revert unrelated change * Remove unrelated slot change * Add casting disclaimer * Don't use facadeValues * Remove dependency on mock facade * Update comment * Remove //@ts-ignore * useAuthenticatorValue cleanup * Update packages/vue/src/composables/useAuth.ts * Update packages/vue/src/composables/useAuth.ts * Update packages/vue/src/composables/useAuth.ts * Update tests * fix typo * Share mockServiceFacade value * Ignore __mock__ dir * Update threshold * Remove typo * update mockServiceFacade usage * Rename baseMockServiceFacade * Update jest ignorePath * jest cleanup * Update packages/vue/src/components/__tests__/federated-sign-in-button.spec.ts * Add @deprecate * Update packages/vue/src/components/federated-sign-in-button.vue
) * WIP * Add qrFields to `useAuthenticator` * SetupTOTP tests * add confirm sign in refactor + tests * Bump jest thresholds * Update packages/vue/src/components/setup-totp.vue * Update packages/vue/src/components/setup-totp.vue * Update packages/vue/src/components/setup-totp.vue * Use type annotation
* refactor confirm reset password * refactor ForceNewPassword * Bump threshold * in progress code * composable tests * alias-control tests * Use ! instead * Turn off non-null assertion * Clean up Authenticator * Update packages/vue/src/components/authenticator.vue * Authenticator cleanup * Update packages/vue/src/components/authenticator.vue * Update comment * Define interface in the file * Update packages/vue/src/components/authenticator.vue * Update packages/vue/src/types/index.ts * Update packages/vue/src/types/index.ts
|
wlee221
commented
Jul 17, 2023
Comment on lines
-12
to
+19
| branches: 22, | ||
| functions: 22, | ||
| lines: 46, | ||
| statements: 45, | ||
| branches: 89, | ||
| functions: 90, | ||
| lines: 93, | ||
| statements: 93, |
reesscot
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Refactors Vue Authenticator components, primarily to use
useAuthenticatorinstead of internaluseAuth. Also adds unit test coverage.All commits other than temporary setups were reviewed through PRs:
Description of how you validated changes
New unit tests, existing e2e test, and smoke tests (done against the latest commit):
sign-in.mov
sign-up+confirm-sign-up.mov
setup-totp+confirm-sign-in.totp.mov
reset-password+confirm-reset-password.mov
force-new-password.mov
verify-user+confirm-verify-user.mov
federated-sign-in.mov
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.