fix(primitives): fixes ts strict errors Alert/Autocomplete #3292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reesscot
commented
Jan 11, 2023
| @@ -36,40 +36,38 @@ const AlertPrimitive: Primitive<AlertProps, typeof Flex> = ( | |||
| } | |||
| }, [setDismissed, onDismiss, dismissed]); | |||
|
|
|||
| return ( | |||
| !dismissed && ( | |||
There was a problem hiding this comment.
TypeScript didn't like this because it means Alert can return false, which is not a valid ReactElement
reesscot
commented
Jan 11, 2023
| @@ -10,7 +10,7 @@ import { | |||
| } from '../Icon/internal'; | |||
|
|
|||
| interface AlertIconProps { | |||
| variation: AlertVariations; | |||
| variation?: AlertVariations; | |||
There was a problem hiding this comment.
Default variation of Alert and AlertIcon is actually no icon
joebuono
approved these changes
Jan 11, 2023
wlee221
approved these changes
Jan 11, 2023
calebpollman
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes TS Strict errors in Alert and Autocomplete primitives.
Description of how you validated changes
yarn react build
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.