Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-amplify): Amplify.register is called per-instance, not per-import #6844

Closed
wants to merge 9 commits into from
Closed

fix(aws-amplify): Amplify.register is called per-instance, not per-import #6844

wants to merge 9 commits into from

Commits on Sep 21, 2020

  1. Revert "Register category to Amplify on import, not instantiation" 

    This reverts commit 167c787.
    @ericclemmons
    ericclemmons committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    577a2c6 View commit details
    Browse the repository at this point in the history

  2. Only Amplify.register in the browser to prevent SSR memory leaks

    @ericclemmons
    ericclemmons committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    9968d85 View commit details
    Browse the repository at this point in the history

  3. Update test to indicate Amplify.register is called per-instance

    @ericclemmons
    ericclemmons committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    905f6ca View commit details
    Browse the repository at this point in the history

  4. Fix import of browserOrNode

    @ericclemmons
    ericclemmons committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    db83aad View commit details
    Browse the repository at this point in the history

  5. Remove browserOrNode().isBrowser check for PushNotification 

    This only gets ran on iOS, not Web
    @ericclemmons
    ericclemmons committed Sep 21, 2020
    Configuration menu
    Copy the full SHA
    dfa2114 View commit details
    Browse the repository at this point in the history

  6. Update packages/pushnotification/__tests__/PushNotification-test.ts 

    Co-authored-by: Alex Hinson <alexmhinson@gmail.com>
    @ericclemmons @amhinson
    ericclemmons and amhinson authored Sep 21, 2020
    Configuration menu
    Copy the full SHA
    1300192 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2020

  1. Fix references to JS.browserOrNode so mocks work

    @ericclemmons
    ericclemmons committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    5f2e531 View commit details
    Browse the repository at this point in the history

  2. Amplify.register is called in every environment but node

    @ericclemmons
    ericclemmons committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    79b57ee View commit details
    Browse the repository at this point in the history

  3. Ensure browserOrNode returns isBrowser: true & isNode: false

    @ericclemmons
    ericclemmons committed Sep 22, 2020
    Configuration menu
    Copy the full SHA
    68e1875 View commit details
    Browse the repository at this point in the history