-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(@aws-amplify/datastore): Sync Status Notification. Performance Improvements. #5942
feat(@aws-amplify/datastore): Sync Status Notification. Performance Improvements. #5942
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #5942 +/- ##
==========================================
- Coverage 73.75% 73.61% -0.14%
==========================================
Files 203 205 +2
Lines 11995 12553 +558
Branches 2258 2444 +186
==========================================
+ Hits 8847 9241 +394
- Misses 2985 3122 +137
- Partials 163 190 +27
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more time to review, but had a question about Hub
's API change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing Job @manueliglesias 🏅 🏅 💯
Just minor questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 🎉 🏅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, @manueliglesias! Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @manueliglesias 👏
It works great team! Congrats. Keep up the good work! |
Thank you @manueliglesias this is awesome 💯 |
@manueliglesias I again notice performance issues on Chrome. Shall I make a new issue for this? |
Ps. I only notice this on chrome on Android but not on the Mac. |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Fixes: #4808
Fixes: #5077
Fixes: #5434
Fixes: #5592
Fixes: #5632
Closes: #5764
Description of changes:
DataStore.start()
to kick of the sync process without having to run a query firstsyncPageSize
from100
to1000
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.