Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for issue 1790 #1802

Merged
merged 3 commits into from
Oct 1, 2018
Merged

fix for issue 1790 #1802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c0a4c7
fix for issue 1790
powerful23 Oct 1, 2018
aacc2ce
minor change
powerful23 Oct 1, 2018
4933f5e
Merge branch 'master' into fix-issue-1790
powerful23 Oct 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/analytics/src/Providers/AWSPinpointProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ export default class AWSPinpointProvider implements AnalyticsProvider {

// flush event buffer
this._setupTimer();

logger.warn(
'Please ensure you have updated you Pinpoint IAM Policy' +
'with the Action: \"mobiletargeting:PutEvents\" in order to' +
'continue using AWS Pinpoint Service'
);
}

private _setupTimer() {
Expand Down
4 changes: 3 additions & 1 deletion packages/core/src/RNComponents/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
* and limitations under the License.
*/

import JS from '../JS';

const Linking = {};
const AppState = {
addEventListener(action, handler) {
Expand All @@ -19,6 +21,6 @@ const AppState = {
};

// if not in react native, just use local storage
const AsyncStorage = window? window.localStorage : undefined;
const AsyncStorage = JS.browserOrNode().isBrowser ? window.localStorage : undefined;

export { Linking, AppState, AsyncStorage };