fix: device tracking for MFA #14626
Open
fix: device tracking for MFA #14626
+88
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soberm
requested review from
avi-karthik,
pranavosu and
sarayev
as code owners
ahmedhamouda78
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Enhanced MFA challenge flow to support device authentication by adding device metadata retrieval and
DEVICE_SRP_AUTHhandling. ModifiedhandleMFAChallengefunction to include device metadata in challenge responses and added proper handling forDEVICE_SRP_AUTHchallenges. This solves the issue where a device is remembered multiple times when using MFA.Key changes:
• Added
tokenOrchestratorparameter toHandleAuthChallengeRequestinterface• Modified
handleMFAChallengeto callgetDeviceMetadataand includeDEVICE_KEYin responses when device metadata exists• Added
DEVICE_SRP_AUTHchallenge detection that invokeshandleDeviceSRPAuthwith correct parameters• Streamlined implementation maintains existing challenge handling patterns for consistency
Issue #, if available
#14622
Description of how you validated changes
• Unit tests
Checklist
• [x] PR description included
• [x] yarn test passes
• [x] Unit Tests are changed or added
• [ ] Relevant documentation is changed or added (and PR referenced)
Checklist for repo maintainers
• [ ] Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
• [ ] New source file paths included in this PR have been added to CODEOWNERS, if appropriate
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.