Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kinesis analytics event type #11167

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: kinesis analytics event type #11167

wants to merge 2 commits into from

Conversation

bokuweb
Copy link

@bokuweb bokuweb commented Mar 31, 2023 •
edited
Loading

Description of changes

It seems that partitionKey in KinesisAnalyticsEvent should be optional?

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bokuweb bokuweb requested a review from a team as a code owner March 31, 2023 04:43
@tannerabread tannerabread added first-time-contributor The contribution is the first for this user in the repo external-contributor labels Apr 12, 2023
@stocaaro
Copy link
Member

It seems that partitionKey in KinesisAnalyticsEvent should be optional?

Can you provide more information about why it should be optional? Do you have any sample code? Are you encountering a problem that this change resolves?

@stocaaro stocaaro self-assigned this Apr 14, 2023
@cwomack
Copy link
Member

cwomack commented Sep 17, 2024

@bokuweb, wanted to follow up on this PR to see if we can get more context. It looks like the Partition Key is required per the Amazon Kinesis docs. Is there a scenario where you'd need this to be optional? Thanks.

@cwomack cwomack self-assigned this Sep 17, 2024
@cwomack cwomack added the pending-community-response Issue is pending a response from the author or community. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cwomack cwomack

Labels
external-contributor first-time-contributor The contribution is the first for this user in the repo pending-community-response Issue is pending a response from the author or community.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bokuweb @stocaaro @cwomack @tannerabread