Skip to content

Commit

Permalink
fix: AuthenticationHelper - Handle negative BigIntegers (#7618)
Browse files Browse the repository at this point in the history 
* fix: Handle negative BigIntegers

Using two's complement for negative numbers

* Address PR comments

* Address comments

* Remove unused variable

* Update packages/amazon-cognito-identity-js/src/AuthenticationHelper.js

Co-authored-by: crockeea <ecrockett0@gmail.com>

* Update packages/amazon-cognito-identity-js/src/AuthenticationHelper.js

Co-authored-by: crockeea <ecrockett0@gmail.com>

* Address PR comments

* Move special case handling to negative block

* Pad SaltToHashDevices

* Make SaltToHashDevices to be unambiguously represented as a postive integer

Co-authored-by: Sam Martinez <samlmar@amazon.com>
Co-authored-by: crockeea <ecrockett0@gmail.com>
  • Loading branch information
@manueliglesias @sammartinez @crockeea
3 people authored Feb 18, 2021
1 parent 3e423d0 commit 104b278
Show file tree
Hide file tree
Showing 4 changed files with 644 additions and 19 deletions.
Loading

0 comments on commit 104b278

Please sign in to comment.