-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
top-level error handling #865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
requested review from
sobolk,
Amplifiyer and
srquinn21
as code owners
January 4, 2024 01:51
🦋 Changeset detectedLatest commit: ff16f27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sobolk
previously approved these changes
Jan 4, 2024
sobolk
approved these changes
Jan 4, 2024
0618
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
edwardfoyle
added
the
run-e2e
Label that will include e2e tests in PR checks workflow
label
Jan 4, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The error handler attached to the yargs commands does not execute if an error is thrown by a sigint handler (or any other process listener). This meant that if a customer hit ctrl+C to stop sandbox (which invokes the sigint handler), then hit ctrl+C again to exit the "do you want to delete the sandbox" prompt, the error thrown by inquirer in the sigint handler would not go through the yargs error handler and instead becomes a top-level unhandled rejection
Issue number, if available:
Fixes #821
Changes
Corresponding docs PR, if applicable:
Validation
Tested various failure scenarios locally, updated unit tests, existing tests pass and added additional unit tests
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.