Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type errors when building tests #1697

Merged
merged 5 commits into from
Jun 28, 2024
Merged

Fix type errors when building tests #1697

merged 5 commits into from
Jun 28, 2024

Conversation

rtpascual
Copy link
Contributor

@rtpascual rtpascual commented Jun 28, 2024

Problem

Canaries are failing on the Install and build without lock file step due to an upgrade to one of our dependencies, @types/node. See example of failing run: https://github.com/aws-amplify/amplify-backend/actions/runs/9718464901.

Issue number, if available:

Changes

Update where types were incorrect when mocking in our tests.

Corresponding docs PR, if applicable:

Validation

Canary run with latest changes https://github.com/aws-amplify/amplify-backend/actions/runs/9719393915

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rtpascual rtpascual requested a review from a team as a code owner June 28, 2024 22:09
Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 6353e3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Kamil Sobol <sobkamil@amazon.com>
@sobolk sobolk merged commit bc20ab1 into main Jun 28, 2024
34 of 35 checks passed
@sobolk sobolk deleted the fix-test-types branch June 28, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants