-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix type errors when building tests #1697
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6353e3b The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/form-generator/src/local_codegen_graphql_form_generator.test.ts
Fixed
Show fixed
Hide fixed
packages/form-generator/src/local_codegen_graphql_form_generator.test.ts
Fixed
Show fixed
Hide fixed
sobolk
reviewed
Jun 28, 2024
Co-authored-by: Kamil Sobol <sobkamil@amazon.com>
sobolk
approved these changes
Jun 28, 2024
0618
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Canaries are failing on the
Install and build without lock file
step due to an upgrade to one of our dependencies,@types/node
. See example of failing run: https://github.com/aws-amplify/amplify-backend/actions/runs/9718464901.Issue number, if available:
Changes
Update where types were incorrect when mocking in our tests.
Corresponding docs PR, if applicable:
Validation
Canary run with latest changes https://github.com/aws-amplify/amplify-backend/actions/runs/9719393915
Checklist
run-e2e
label set.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.