Bump PR size check. #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardfoyle
reviewed
May 19, 2023
|
|
||
| const MAX_LINES_ADDED = 200; | ||
| const MAX_LINES_REMOVED = 200; | ||
| const MAX_LINES_ADDED = 1000; |
Contributor
There was a problem hiding this comment.
The goal I'd like to aim for here is 30 min reviews (or less). I'm open to bumping this up but worried it will only ever go up. Another knob we could tweak before raising this too much is to exclude some config files. This won't help in all cases, but in cases where we are adding a new dev tool or a new package this will prevent some of the config boilerplate from counting towards the line limit
Contributor
Author
There was a problem hiding this comment.
I've extrapolated these numbers from PRs we already had and nobody complained about size. All were reviewable in <10 minutes for me at least.
I do agree that we should not keep bumping that. But I think we started to strict.
edwardfoyle
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Something more realistic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.