docs: update README and logging with information on new mask-password input #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelb990
suggested changes
Aug 8, 2023
therealdwright
approved these changes
Aug 8, 2023
michaelb990
approved these changes
Aug 9, 2023
|
Did you ever read this? #483 (comment) |
|
In our case we need the Docker credentials in order to pull an image from ecr in the following job, by showing this warning the credentials are more in the picture then before or as a Dutch saying goes: "Waking up sleeping dogs" |
|
@arjraman is it possible to remove the warnings? Because if you need unmasked values to pass to other jobs, you don't want to show that the credentials are unmasked? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#491
Description of changes:
Update README and logging with information on new mask-password input.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.