Skip to content

Commit

Permalink
Remove remaining SKIP_LINK=1 in circleci config (#9669)
Browse files Browse the repository at this point in the history
Summary:
Should be unnecessary

Pull Request resolved: facebook/rocksdb#9669

Test Plan: CI

Reviewed By: ajkr

Differential Revision: D34689277

Pulled By: pdillinger

fbshipit-source-id: 5d44de1f851503fd1777b869c06c330f3c4deade
  • Loading branch information
pdillinger authored and facebook-github-bot committed Mar 7, 2022
1 parent 785b804 commit 9b8b8b1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,7 @@ jobs:
steps:
- pre-steps
- run: sudo apt-get update -y && sudo apt-get install gcc-10 g++-10 libgflags-dev
- run: CC=gcc-10 CXX=g++-10 V=1 SKIP_LINK=1 ROCKSDB_CXX_STANDARD=c++20 make -j16 all # Linking broken because libgflags compiled with newer ABI
- run: CC=gcc-10 CXX=g++-10 V=1 ROCKSDB_CXX_STANDARD=c++20 make -j16 all
- post-steps

build-linux-gcc-11-no_test_run:
Expand All @@ -433,7 +433,7 @@ jobs:
- pre-steps
- install-benchmark
- run: sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test && sudo apt-get update -y && sudo apt-get install gcc-11 g++-11 libgflags-dev
- run: CC=gcc-11 CXX=g++-11 V=1 SKIP_LINK=1 make -j16 all microbench # Linking broken because libgflags compiled with newer ABI
- run: CC=gcc-11 CXX=g++-11 V=1 make -j16 all microbench
- post-steps

build-linux-clang-13-no_test_run:
Expand Down

0 comments on commit 9b8b8b1

Please sign in to comment.