Rename method as a homage to my tenage years

awitten1 · Apr 19, 2024 · bc18ac8 · bc18ac8
1 parent 9da0f63
commit bc18ac8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/src/execution/operator/csv_scanner/sniffer/header_detection.cpp b/src/execution/operator/csv_scanner/sniffer/header_detection.cpp
@@ -124,8 +124,8 @@ bool CSVSniffer::DetectHeaderWithSetColumn() {
 			const auto &sql_type = (*set_columns.types)[col];
 			if (sql_type != LogicalType::VARCHAR) {
 				all_varchar = false;
-				if (!IsCasteable(best_header_row[col].value, sql_type, options.dialect_options,
-				                 best_header_row[col].IsNull())) {
+				if (!CanYouCastIt(best_header_row[col].value, sql_type, options.dialect_options,
+				                  best_header_row[col].IsNull())) {
 					first_row_consistent = false;
 				}
 			}
@@ -176,8 +176,8 @@ void CSVSniffer::DetectHeader() {
 			const auto &sql_type = best_sql_types_candidates_per_column_idx[col].back();
 			if (sql_type != LogicalType::VARCHAR) {
 				all_varchar = false;
-				if (!IsCasteable(best_header_row[col].value, sql_type, sniffer_state_machine.dialect_options,
-				                 best_header_row[col].IsNull())) {
+				if (!CanYouCastIt(best_header_row[col].value, sql_type, sniffer_state_machine.dialect_options,
+				                  best_header_row[col].IsNull())) {
 					first_row_consistent = false;
 				}
 			}

diff --git a/src/execution/operator/csv_scanner/sniffer/type_detection.cpp b/src/execution/operator/csv_scanner/sniffer/type_detection.cpp
@@ -93,8 +93,8 @@ void CSVSniffer::SetDateFormat(CSVStateMachine &candidate, const string &format_
 	candidate.dialect_options.date_format[sql_type].Set(strpformat, false);
 }
 
-bool CSVSniffer::IsCasteable(const string_t value, const LogicalType &type, const DialectOptions &dialect_options,
-                             const bool is_null) {
+bool CSVSniffer::CanYouCastIt(const string_t value, const LogicalType &type, const DialectOptions &dialect_options,
+                              const bool is_null) {
 	if (is_null) {
 		return true;
 	}
@@ -315,8 +315,8 @@ void CSVSniffer::DetectTypes() {
 						// Nothing to convert it to
 						continue;
 					}
-					if (IsCasteable(vector_data[row_idx], sql_type, sniffing_state_machine.dialect_options,
-					                !null_mask.RowIsValid(row_idx))) {
+					if (CanYouCastIt(vector_data[row_idx], sql_type, sniffing_state_machine.dialect_options,
+					                 !null_mask.RowIsValid(row_idx))) {
 						break;
 					} else {
 						if (row_idx != start_idx_detection && cur_top_candidate == LogicalType::BOOLEAN) {

diff --git a/src/include/duckdb/execution/operator/csv_scanner/csv_sniffer.hpp b/src/include/duckdb/execution/operator/csv_scanner/csv_sniffer.hpp
@@ -165,8 +165,8 @@ class CSVSniffer {
 	void DetectDateAndTimeStampFormats(CSVStateMachine &candidate, const LogicalType &sql_type, const string &separator,
 	                                   string_t &dummy_val);
 	//! If a string_t value can be cast to a type
-	bool IsCasteable(const string_t value, const LogicalType &type, const DialectOptions &dialect_options,
-	                 const bool is_null);
+	bool CanYouCastIt(const string_t value, const LogicalType &type, const DialectOptions &dialect_options,
+	                  const bool is_null);
 
 	//! Variables for Type Detection
 	//! Format Candidates for Date and Timestamp Types