Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change edition mode to editing mode in documentation #28

Merged
merged 1 commit into from
Jul 15, 2019
Merged

Change edition mode to editing mode in documentation #28

merged 1 commit into from
Jul 15, 2019

Conversation

ibnesayeed
Copy link

I think an edition refers to a version of some published material. If I understood the intent of the documentation correctly, perhaps it should be editing mode or simply edit mode.

mjarkk
mjarkk approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@mjarkk mjarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good pickup, this is indeed wrong!

glvr182
glvr182 approved these changes Jul 15, 2019
View reviewed changes
Copy link
Member

@glvr182 glvr182 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glvr182 glvr182 merged commit 209c645 into awesome-gocui:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glvr182 glvr182 glvr182 approved these changes

@mjarkk mjarkk mjarkk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ibnesayeed @mjarkk @glvr182