Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnitTest for product view #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hoanghaiphongg
Copy link
Contributor

@hoanghaiphongg hoanghaiphongg commented Aug 28, 2024

Checklist tự review pull trước khi ready để trainer review

  • Sử dụng thụt lề 2 spaces/4 spaces đồng nhất ở tất cả các files (setting lại vscode /sublime text/ ... nếu chưa cài đặt)
  • Cuối mỗi file kiểm tra có end line (khi đẩy lên git xem file change không bị lỗi tròn đỏ ở cuối file)
  • Mỗi dòng nếu quá dài, cần xuống dòng (maximum: 80 kí tự mỗi dòng, setting trong IDE)
  • Tham khảo Python coding convention https://peps.python.org/pep-0008/
  • Kiểm tra mỗi pull request chỉ 1 commit, nếu nhiều hơn 1 commit thì hãy gộp commit thành 1 rồi đẩy lại lên git
  • Install PEP8 ở local để check và fix các lỗi liên quan đến syntax, coding convention. Khi gửi thì chụp ảnh PASS đính kèm trong pull
  • Nếu làm việc nhóm trong project thì mỗi pull cần ít nhất 1 APPROVED từ thành viên trong nhóm

Related Tickets

WHAT (optional)

  • Change number items completed/total in admin page.

HOW

  • I edit js file, inject not_vary_normal items in calculate function.

WHY (optional)

  • Because in previous version - number just depends on normal items. But in new version, we have state and confirm_state depends on both normal + not_normal items.

Evidence (Screenshot or Video)

image
Pass pycodestyle :
image

Notes (Kiến thức tìm hiểu thêm)

@hoanghaiphongg hoanghaiphongg changed the title Done unittest for product view UnitTest for product view Aug 28, 2024
@hoanghaiphongg hoanghaiphongg force-pushed the unittest_filter_product branch 3 times, most recently from bde16c2 to 98bb1cd Compare August 28, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant