task 12008+09+10: Search Movie Screen: Create UI + Handle Event + Fetch API #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ready |
tienpx3010
reviewed
May 24, 2019
| @@ -121,6 +121,12 @@ final class MovieDetailViewController: UIViewController, AlertViewController, Bi | |||
| output.error | |||
| .drive(errorBinding) | |||
| .disposed(by: disposeBag) | |||
| Observable.of(output.titleMovie.mapToVoid().asObservable(), | |||
| let movieRepository: MovieRepository | ||
| let genreRepository: GenreReponsitory | ||
|
|
||
| func searchMovie(query: String, page: Int) -> Observable<([Movie], Int)> { |
There was a problem hiding this comment.
Khai báo class với generic và page chứ k truyền tuple thế này
There was a problem hiding this comment.
Khai báo class với generic và page chứ k truyền tuple thế này
Em chưa hiểu lắm, anh có thể lấy ví dụ được không?
| }) | ||
| let selectMovie = input.movieSelectTrigger | ||
| .withLatestFrom(movies.asDriver()) { indexPath, movies in | ||
| return (movies[indexPath.row], indexPath) |
There was a problem hiding this comment.
Suggested change
| return (movies[indexPath.row], indexPath) | |
| return ($1[$0.row], $0) |
| return self.selectedGenres | ||
| .asDriver() | ||
| .map { genres in | ||
| return genres.filter { $0.selected }.map { $0.id } |
There was a problem hiding this comment.
Suggested change
| return genres.filter { $0.selected }.map { $0.id } | |
| return genres.filter { $0.selected } | |
| .map { $0.id } |
| .mapToVoid() | ||
| let paging = input.pageTrigger | ||
| .withLatestFrom(isSearching.asDriver(onErrorJustReturn: false)) { page, isSearching in | ||
| return (page, isSearching) |
There was a problem hiding this comment.
Suggested change
| return (page, isSearching) | |
| return ($0, $1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link 🔗
https://edu-redmine.sun-asterisk.vn/issues/12007
Goals ⚽
----Create UI:
https://marvelapp.com/be90ba4/screen/56474035
----Handle Event:
Fetch data and display to UI:
Implementation Details 🚧
https://gfycat.com/FeistySadCrocodile