updating test code to current standards

[mdruger]

This is the start of an iteration for updating code to current formatting standards.
Also, replace dingus module with mock module.

Testing:
run in virtualenv
$ python setup.py nosetests

[JohnBrodie]

Dingus is still installed, but mock is not (see setup.py and tox.ini).

[JohnBrodie]

The test coverage here has a few holes in it.

[JohnBrodie]

trailing comma

[JohnBrodie]

There are still a bunch of bare asserts mixed in with unittest2 assertions, the bare asserts should be changed.

[JohnBrodie]

➜  AWeber-API-Python-Library git:(test-code-std-update) ✗ pep8 tests/*.py
zsh: /usr/bin/pep8: bad interpreter: /Volumes/aweber/github/salesforce-data-sync/bin/python: no such file or directory
tests/test_aweber_collection.py:50:28: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
tests/test_aweber_collection.py:101:51: E712 comparison to True should be 'if cond is True:' or 'if cond:'
tests/test_aweber_entry.py:106:28: E712 comparison to False should be 'if cond is not False:' or 'if cond:'
tests/test_aweber_entry.py:171:46: E203 whitespace before ','
tests/test_aweber_entry.py:182:45: E203 whitespace before ','
tests/test_aweber_entry.py:183:13: E128 continuation line under-indented for visual indent
tests/test_aweber_entry.py:216:41: E203 whitespace before ','

[JohnBrodie]

Looks like we dislike super in the tests as well for some reason, we should change that.

[JohnBrodie]

It looks like many of the tests could easily be switched to use setUpClass instead of setUp to minimize the setup/teardown time in the tests.

[JohnBrodie]

There are still backslashes used in files like test_aweber_collection that should go away.

[JohnBrodie]

So, if we want to bring the tests in line with what we would consider our "modern" codebase, there is a lot more work to be done here than just syntax fixes.

The lowest hanging fruit would be things like:

class AWeberAPITest(TestCase):

    def setUp(self):
        self.aweber = AWeberAPI(key, secret)

    def test_should_exist(self):
        self.assertTrue(self.aweber)

But these tests are a mix of broad unit-tests and heavily mocked integration tests. That would have to be fixed... Much of the tests would essentially have to be rewritten. That's likely more work than we want to do?

[JohnBrodie]

I'll also mention code coverage again. Instead of saying "install this in a venv" in the README, it'd be great if there were a simple Makefile with a few targets....

[JohnBrodie]

Tests fail locally on on Travis due to import issues.

[JohnBrodie]

This will need to be rebased.

[ghost]

This needs to be rebased off of the most version of master.

[chrismcguire]

Are either of these methods ever used?

[mdruger]

removed.

[pianoman19372]

these comments should be removed

[mdruger]

removed.

[pianoman19372]

i ran pep8, the 2 whitespace checks chris remarked show there.

i also ran pylint, and found these errors:
4 cases: Catching too general exception Exception
3 cases: Dangerous default value {} as argument
1 case: Redefining built-in 'file'
2 case: Redefining built-in 'list'

Unused variables and arguments: could be ok, just verify that these are a result of a mock, instead of a helper function

Docstrings are not required in most test functions, but if you wrote a helper method it should have a docstring. verify that all helper methods have docstrings.
mock_adapter.py:1: [C] Missing docstring

miked: I ran pylint and pep 8 on all files. verified that the pertinent warning messages were addressed.
I fixed all that is highlighted above. However, the Missing docstring in the mock_adaptor.py file as well as other files reported does not apply. Verified that helper functions had docstrings, but there are no helper functions in the tests.