Skip to content
This repository was archived by the owner on Aug 29, 2019. It is now read-only.

Conversation

@mdruger
Copy link

@mdruger mdruger commented Feb 13, 2014

refers to PPACL-6

adjust the regex pattern for the url test. This was found to not work when testing with tox. tox is being added in card PPACL-2, so this card is a blocker.

Test this in a virtualenv and run
$ python setup.py nosetests

@vrajmohan
Copy link

Looking at the JIRA card PPACL-6, it is difficult for me to assess the issue and the resolution. The card is worded like a self-fulfilling prophesy with the issue being the code change needed :-). Can you please shed some more light so that I can do a better job of reviewing the change?

@mdruger
Copy link
Author

mdruger commented Feb 13, 2014

I came across this issue, when I was adding tox to the AWeber API Python Client Library
when I added tox to run tests for different versions of python, the original tests failed on these lines.
So when you brought this up, I revisited it and now, of course, they are running without the change
so, I am going to close this card as it is not necessary

@mdruger mdruger closed this Feb 13, 2014
@mdruger mdruger reopened this Feb 13, 2014
@mdruger mdruger closed this Feb 13, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants