Generated code no longer depends on grpc-haskell-core
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #53 The motivation for this change is so that generated code does not need to depend on the `grpc-haskell-core` package This removes the unnecessary `Network.GRPC.HighLevel.Server.Unregistered` import from the generated code since everything provided by the low-level library is already re-exported by the high-level library
ixmatus
approved these changes
Mar 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes awakesecurity/gRPC-haskell#53
The motivation for this change is so that generated code does not need to
depend on the
grpc-haskell-corepackageThis removes the unnecessary
Network.GRPC.HighLevel.Server.Unregisteredimport from the generated code since everything provided by the low-level
library is already re-exported by the high-level library
I tested this against the
gRPC-haskelltest suite, which still passed after thischange