Use "ghc" library in place of "haskell-src". #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "ghc" library is now used to parse and print Haskell source code. Switching to "ghc" adds support for language features beyond Haskell 98 and improves diagnostic messages for sources specified with "--extraInstanceFile". Breakage should be limited to users of: * Proto3.Suite.DotProto.Generate * Proto3.Suite.DotProto.Generate.LargeRecord * Proto3.Suite.DotProto.Generate.Syntax To reflect the potential for breakage we increase the library version to 0.8.0. This change also replaces testing of GHC 8.10.7 with testing of 9.6.4, and indicates in CHANGELOG.md that we are dropping support for GHC 8.10 and adding support for GHC 9.6. This change also fixes some build failures that occurred when Swagger support is disabled.
CI replaces ghc924 with ghc928 and ghc946 with ghc948.
Include ghc981 in CI testing. Test all valid combinations of flags, except for large-records on GHC 9.6+ and dhall on GHC 9.8, neither of which is currently possible.
riz0id
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "ghc" library is now used to parse and print Haskell source code.
Switching to "ghc" adds support for language features beyond Haskell 98
and improves diagnostic messages for sources specified with
"--extraInstanceFile". Breakage should be limited to users of:
To reflect the potential for breakage
we increase the library version to 0.8.0.
This change also replaces testing of
GHC 8.10.7 with testing of GHC 9.6.2
and GHC 9.8.1, and indicates in
CHANGELOG.md that we are dropping
support for GHC 8.10 and adding
support for GHC 9.6.
This change also fixes some build failures that
occurred when Swagger support is disabled,
and expands the flag combinations to all the
ones currently supported.
Support for dhall and large-records is limited
in more recent versions of GHC due to
problems with building those dependencies.