Skip to content

Conversation

@tarampampam
Copy link
Contributor

@tarampampam tarampampam commented Feb 14, 2020

Q A
Bug fix? Yes or No
New feature? Yes or No

Description

v3.0.0

Added

  • PHP 7.4 supports ang tests running
  • Method ->repository(): RepositoryInterface in AvtoDev\AppVersion\AppVersionManager
  • Interfaces:
    • AvtoDev\AppVersion\Drivers\DriverInterface
    • AvtoDev\AppVersion\Repositories\RepositoryInterface
  • Artisan command version supports new arguments - --get-segment, --set-version
  • Drivers (repository factories):
    • AvtoDev\AppVersion\Drivers\ChangelogFileDriver
    • AvtoDev\AppVersion\Drivers\ConfigFileDriver
    • AvtoDev\AppVersion\Drivers\FileDriver
  • Repositories:
    • AvtoDev\AppVersion\Repositories\ChangelogFileRepository
    • AvtoDev\AppVersion\Repositories\ConfigFileRepository
    • AvtoDev\AppVersion\Repositories\FileRepository
    • AvtoDev\AppVersion\Repositories\NullRepository

Changed

  • Config file location (./src/config/version.php./config/version.php)
  • Config file structure (totally)
  • Minimal symfony/console version now is ^4.4 (reason: [CONSOLE] PHP 7.4: Trying to access array offset on value of type int symfony/symfony#32750)
  • ->formatted() method signature to ->formatted(string $format) in AvtoDev\AppVersion\AppVersionManager
  • Interface AvtoDev\AppVersion\Contracts\AppVersionManagerContractAvtoDev\AppVersion\AppVersionManagerInterface

Removed

  • Facade AvtoDev\AppVersion\AppVersionFacade
  • Environment APP_VERSION_CONFIG_PATH supports
  • Methods ->major(), ->minor(), ->patch(), ->build(), ->setBuild(), ->refresh() from AvtoDev\AppVersion\AppVersionManager
  • Artisan command version argument --refresh

Deprecated

  • Helpers app_version, app_build and app_version_hash

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote unit tests for my code (if tests is required for my changes)
  • I have made changes in CHANGELOG.md file

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #7 into master will increase coverage by 8.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master     #7      +/-   ##
==========================================
+ Coverage     91.93%   100%   +8.06%     
- Complexity       46    151     +105     
==========================================
  Files             6     11       +5     
  Lines           124    299     +175     
==========================================
+ Hits            114    299     +185     
+ Misses           10      0      -10
Impacted Files Coverage Δ Complexity Δ
src/ServiceProvider.php 100% <100%> (ø) 11 <2> (+2) ⬆️
src/Repositories/NullRepository.php 100% <100%> (ø) 12 <12> (?)
src/Support/Version.php 100% <100%> (ø) 43 <43> (?)
src/Drivers/ChangelogFileDriver.php 100% <100%> (ø) 2 <2> (?)
src/Repositories/ConfigFileRepository.php 100% <100%> (ø) 22 <22> (?)
src/Drivers/FileDriver.php 100% <100%> (ø) 2 <2> (?)
src/Commands/VersionCommand.php 100% <100%> (ø) 13 <13> (+4) ⬆️
src/Repositories/ChangelogFileRepository.php 100% <100%> (ø) 17 <17> (?)
src/Drivers/ConfigFileDriver.php 100% <100%> (ø) 2 <2> (?)
src/Repositories/FileRepository.php 100% <100%> (ø) 19 <19> (?)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9be8220...d69568f. Read the comment docs.

@tarampampam tarampampam self-assigned this Feb 14, 2020
@tarampampam tarampampam added the enhancement New feature or request label Feb 14, 2020
@tarampampam tarampampam merged commit 8485c5e into master Feb 14, 2020
@tarampampam tarampampam deleted the v3 branch February 14, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

3 participants