Possible bug with invalidated rows

[mbijnsdorp]

Hi,

I'm running into the following issue with my customer import, but I found the same logic is also applied to the other imports.

Say I want to import 5 customer rows. Row number 1 contains invalid data (duplicate email) and the row number is added to _invalidRows. The data for this row will not be prepared for import, so is no longer included in the bunches.

When the import comes to importing the data after it has been validated (continue after errors is set to yes), there are 4 rows remaining, but the rownumbers are reset, so we have row 0 to 3. When the importer validates each row in the _saveCustomers() function, it says row number 1 is invalid. However this is no longer true, as row number 1 is no longer in the bunch data, so actually valid data is invalidated and not imported.

[Rud5G]

@paales can you check this, i have similar results.

[paales]

@mbijnsdorp @Rud5G I believe the proposed fix isn't the fix we are looking for.

The same code is present in the products and categories importer:
https://github.com/avstudnitz/AvS_FastSimpleImport/blob/master/src/app/code/community/AvS/FastSimpleImport/Model/Import/Entity/Product.php#L1453-L1459
https://github.com/avstudnitz/AvS_FastSimpleImport/blob/master/src/app/code/community/AvS/FastSimpleImport/Model/Import/Entity/Category.php#L1156-L1162

The original commit was the fix for more than one issue: 2143daf I'm not really sure how to fix the issue right now without really digging into it.

[mbijnsdorp]

@paales What about removing the validateRow from the _saveCustomers() function:

if (!$this->validateRow($rowData, $rowNum)) {
    continue;
}

As invalid data has already been removed from the bunch data, this one is now only causing issues (as far as I have seen)