fix: Removed AvroNamespaceOverride as it was not fully implemented

README.md

@@ -737,30 +737,6 @@ package my.package
 data class MyData(val myField: String)
 ```
 
-## Changing the namespace of all nested named type(s)
-
-Sometimes, using classes from other packages or libraries, you may want to change the namespace of a nested named type. This is done annotating the field
-with `@AvroNamespaceOverride`.
-
-```kotlin
-import kotlinx.serialization.Serializable
-import com.github.avrokotlin.avro4k.AvroNamespaceOverride
-
-@Serializable
-data class MyData(
-    @AvroNamespaceOverride("new.namespace") val myField: NestedRecord
-)
-
-// ...
-package external.package.name
-
-@Serializable
-data class NestedRecord(val field: String)
-```
-
-> [!NOTE]
-> This impacts the schema generation, the serialization and the deserialization.
-
 ## Change type name (FIXED only)
 
 > [!WARNING]

api/avro4k-core.api

@@ -164,15 +164,6 @@ public final class com/github/avrokotlin/avro4k/AvroKt {
 	public static final fun schema (Lcom/github/avrokotlin/avro4k/Avro;Lkotlinx/serialization/KSerializer;)Lorg/apache/avro/Schema;
 }
 
-public abstract interface annotation class com/github/avrokotlin/avro4k/AvroNamespaceOverride : java/lang/annotation/Annotation {
-	public abstract fun value ()Ljava/lang/String;
-}
-
-public synthetic class com/github/avrokotlin/avro4k/AvroNamespaceOverride$Impl : com/github/avrokotlin/avro4k/AvroNamespaceOverride {
-	public fun <init> (Ljava/lang/String;)V
-	public final synthetic fun value ()Ljava/lang/String;
-}
-
 public final class com/github/avrokotlin/avro4k/AvroObjectContainerFile {
 	public fun <init> ()V
 	public fun <init> (Lcom/github/avrokotlin/avro4k/Avro;)V

src/main/kotlin/com/github/avrokotlin/avro4k/AvroAnnotations.kt → src/main/kotlin/com/github/avrokotlin/avro4k/Annotations.kt

@@ -11,18 +11,6 @@ import kotlinx.serialization.descriptors.SerialDescriptor
 import org.apache.avro.LogicalType
 import org.intellij.lang.annotations.Language
 
-/**
- * When annotated on a property, deeply overrides the namespace for all the nested named types (records, enums and fixed).
- *
- * Works with standard classes and inline classes.
- */
-@SerialInfo
-@ExperimentalSerializationApi
-@Target(AnnotationTarget.PROPERTY)
-public annotation class AvroNamespaceOverride(
-    val value: String,
-)
-
 /**
  * Adds a property to the Avro schema or field. Its value could be any valid JSON or just a string.
  *
@@ -83,6 +71,11 @@ public annotation class AvroFixed(val size: Int)
 /**
  * Sets the default avro value for a record's field.
  *
+ * - Records and maps have to be represented as a json object
+ * - Arrays have to be represented as a json array
+ * - Nulls have to be represented as a json `null`. To set the string `"null"`, don't forget to quote the string, example: `""""null""""` or `"\"null\""`.
+ * - Any non json content will be treated as a string
+ *
  * Ignored in inline classes.
  */
 @SerialInfo
@@ -112,7 +105,7 @@ public annotation class AvroEnumDefault
  * }
  * ```
  *
- * For more complex needs, please file an issue [here](https://github.com/avro-kotlin/avro4k/issues).
+ * For more complex needs, please file an feature request [here](https://github.com/avro-kotlin/avro4k/issues).
  */
 @ExperimentalSerializationApi
 public fun SerialDescriptor.asAvroLogicalType(): SerialDescriptor {

src/main/kotlin/com/github/avrokotlin/avro4k/internal/schema/ClassVisitor.kt

@@ -4,7 +4,6 @@ import com.github.avrokotlin.avro4k.AvroDefault
 import com.github.avrokotlin.avro4k.internal.isStartingAsJson
 import com.github.avrokotlin.avro4k.internal.jsonNode
 import com.github.avrokotlin.avro4k.internal.nonNullSerialName
-import com.github.avrokotlin.avro4k.internal.overrideNamespace
 import kotlinx.serialization.SerializationException
 import kotlinx.serialization.builtins.serializer
 import kotlinx.serialization.descriptors.SerialDescriptor
@@ -99,25 +98,20 @@ internal class ClassVisitor(
         elementDescriptor: SerialDescriptor,
         elementSchema: Schema,
     ): Schema.Field {
-        var finalSchema: Schema = annotations.namespaceOverride?.value?.let { elementSchema.overrideNamespace(it) } ?: elementSchema
+        val fieldDefault = getFieldDefault(annotations.default, elementSchema, elementDescriptor)
 
-        val fieldDefault = getFieldDefault(annotations.default, finalSchema, elementDescriptor)
-
-        if (fieldDefault != null) {
-            reorderUnionIfNeeded(fieldDefault, finalSchema)?.let {
-                finalSchema = it
+        val finalSchema =
+            if (fieldDefault != null) {
+                reorderUnionIfNeeded(fieldDefault, elementSchema)
+            } else {
+                elementSchema
             }
-        }
 
         val field =
             Schema.Field(
-                // name =
                 fieldName,
-                // schema =
                 finalSchema,
-                // doc =
                 annotations.doc?.value,
-                // defaultValue =
                 fieldDefault
             )
         annotations.aliases.flatMap { it.value.asSequence() }.forEach { field.addAlias(it) }
@@ -130,23 +124,23 @@ internal class ClassVisitor(
      */
     private fun reorderUnionIfNeeded(
         fieldDefault: Any,
-        finalSchema: Schema,
-    ): Schema? {
-        if (finalSchema.isUnion && finalSchema.isNullable) {
+        schema: Schema,
+    ): Schema {
+        if (schema.isUnion && schema.isNullable) {
             var nullNotFirst = false
             if (fieldDefault is Collection<*>) {
                 nullNotFirst = fieldDefault.any { it != JsonProperties.NULL_VALUE }
             } else if (fieldDefault != JsonProperties.NULL_VALUE) {
                 nullNotFirst = true
             }
             if (nullNotFirst) {
-                val nullIndex = finalSchema.types.indexOfFirst { it.type == Schema.Type.NULL }
-                val nonNullTypes = finalSchema.types.toMutableList()
+                val nullIndex = schema.types.indexOfFirst { it.type == Schema.Type.NULL }
+                val nonNullTypes = schema.types.toMutableList()
                 val nullType = nonNullTypes.removeAt(nullIndex)
                 return Schema.createUnion(nonNullTypes + nullType)
             }
         }
-        return null
+        return schema
     }
 
     private fun getFieldDefault(

src/main/kotlin/com/github/avrokotlin/avro4k/internal/schema/InlineClassVisitor.kt

@@ -2,7 +2,6 @@ package com.github.avrokotlin.avro4k.internal.schema
 
 import com.github.avrokotlin.avro4k.internal.copy
 import com.github.avrokotlin.avro4k.internal.jsonNode
-import com.github.avrokotlin.avro4k.internal.overrideNamespace
 import kotlinx.serialization.descriptors.SerialDescriptor
 import org.apache.avro.Schema
 
@@ -24,14 +23,13 @@ internal class InlineClassVisitor(
         return ValueVisitor(context.copy(inlinedAnnotations = inlinedAnnotations)) { generatedSchema ->
             val annotations = InlineClassFieldAnnotations(inlineClassDescriptor)
 
-            var schema = generatedSchema
-            if (annotations.namespaceOverride != null) {
-                schema = schema.overrideNamespace(annotations.namespaceOverride.value)
-            }
             val props = annotations.props.toList()
-            if (props.isNotEmpty()) {
-                schema = schema.copy(additionalProps = props.associate { it.key to it.jsonNode })
-            }
+            val schema =
+                if (props.isNotEmpty()) {
+                    generatedSchema.copy(additionalProps = props.associate { it.key to it.jsonNode })
+                } else {
+                    generatedSchema
+                }
 
             onSchemaBuilt(schema)
         }

src/main/kotlin/com/github/avrokotlin/avro4k/internal/schema/VisitorContext.kt

@@ -5,7 +5,6 @@ import com.github.avrokotlin.avro4k.AvroAlias
 import com.github.avrokotlin.avro4k.AvroDefault
 import com.github.avrokotlin.avro4k.AvroDoc
 import com.github.avrokotlin.avro4k.AvroFixed
-import com.github.avrokotlin.avro4k.AvroNamespaceOverride
 import com.github.avrokotlin.avro4k.AvroProp
 import com.github.avrokotlin.avro4k.internal.AnnotatedLocation
 import com.github.avrokotlin.avro4k.internal.findAnnotation
@@ -29,11 +28,9 @@ internal fun VisitorContext.resetNesting() = copy(inlinedAnnotations = null)
  * Contains all the annotations for a field of a class (kind == CLASS && isInline == true).
  */
 internal data class InlineClassFieldAnnotations(
-    val namespaceOverride: AvroNamespaceOverride?,
     val props: Sequence<AvroProp>,
 ) {
     constructor(inlineClassDescriptor: SerialDescriptor) : this(
-        inlineClassDescriptor.findElementAnnotation<AvroNamespaceOverride>(0),
         sequence {
             yieldAll(inlineClassDescriptor.findAnnotations<AvroProp>())
             yieldAll(inlineClassDescriptor.findElementAnnotations<AvroProp>(0))
@@ -53,14 +50,12 @@ internal data class FieldAnnotations(
     val aliases: Sequence<AvroAlias>,
     val doc: AvroDoc?,
     val default: AvroDefault?,
-    val namespaceOverride: AvroNamespaceOverride?,
 ) {
     constructor(descriptor: SerialDescriptor, elementIndex: Int) : this(
         descriptor.findElementAnnotations<AvroProp>(elementIndex).asSequence(),
         descriptor.findElementAnnotations<AvroAlias>(elementIndex).asSequence(),
         descriptor.findElementAnnotation<AvroDoc>(elementIndex),
-        descriptor.findElementAnnotation<AvroDefault>(elementIndex),
-        descriptor.findElementAnnotation<AvroNamespaceOverride>(elementIndex)
+        descriptor.findElementAnnotation<AvroDefault>(elementIndex)
     ) {
         require(descriptor.kind == StructureKind.CLASS) {
             "${FieldAnnotations::class.qualifiedName} is only for classes, but trying at element index $elementIndex with non class descriptor $descriptor"