Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface the release RTD link to GHA workflow summary page #6049

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

webknjaz
Copy link
Contributor

This will additionally display the updated text on pages like https://github.com/avocado-framework/avocado/actions/runs/11215982471.

Here's an example of how job summaries are displayed: https://github.com/ansible/awx-plugins/actions/runs/10793404435#summary-29935289633.

@richtja richtja self-requested a review October 29, 2024 16:35
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.44%. Comparing base (ad418d4) to head (e4cc783).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6049      +/-   ##
==========================================
- Coverage   54.48%   54.44%   -0.05%     
==========================================
  Files         202      202              
  Lines       21874    21882       +8     
==========================================
- Hits        11919    11913       -6     
- Misses       9955     9969      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @webknjaz, thank you for your updates, the changes LGTM. The only issue is that our Signed-off check is failing, because your commit signature slightly differs from your git author's name. Can you please update that, thank you?

Signed-off-by: Sviatoslav Sydorenko (Святослав Сидоренко) webknjaz@redhat.com/Signed-Off-By: Sviatoslav Sydorenko webknjaz@redhat.com

@webknjaz
Copy link
Contributor Author

webknjaz commented Nov 7, 2024

Ah, right.. That's a limitation of PRs made throught web interface, which I go for in case of drive-bys as it's much faster.

This will additionally display the updated text on pages like https://github.com/avocado-framework/avocado/actions/runs/11215982471.

Here's an example of how job summaries are displayed: https://github.com/ansible/awx-plugins/actions/runs/10793404435#summary-29935289633.

Signed-Off-By: Sviatoslav Sydorenko <webknjaz@redhat.com>
@webknjaz
Copy link
Contributor Author

webknjaz commented Nov 7, 2024

done

Copy link
Contributor

@richtja richtja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @webknjaz, thanks for the update, it LGTM.

@richtja richtja merged commit cf92d94 into avocado-framework:master Nov 8, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 109
Development

Successfully merging this pull request may close these issues.

2 participants