drop output-check-record feature #5185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beraldoleal
force-pushed
the
issues/3882
branch
3 times, most recently
from
174e481 to
425ba5a
Compare
|
LGTM. There are still some left overs in |
Maybe those are fixed with the new PR. @ana, I just fixed the |
beraldoleal
force-pushed
the
issues/3882
branch
from
425ba5a to
216bc87
Compare
'on' and 'off' are not being used anymore. Signed-off-by: Beraldo Leal <bleal@redhat.com>
This is working only on legacy runner that we don't support anymore. Also, this it was deprecated at a922b24. Since we are working on a new feature with a complete new design based on the new runner architecture, lets drop to avoid creating the new feature with legacy code. Related to avocado-framework#3882. Signed-off-by: Beraldo Leal <bleal@redhat.com>
We are not supporting the legacy code at this point anymore. Let's drop this portion of the code. Signed-off-by: Beraldo Leal <bleal@redhat.com>
This will improve a little the code readability. Signed-off-by: Beraldo Leal <bleal@redhat.com>
IIUC, this plugin only makes sense with the legacy feature. Signed-off-by: Beraldo Leal <bleal@redhat.com>
beraldoleal
force-pushed
the
issues/3882
branch
from
216bc87 to
f1fe549
Compare
|
I found some of the leftovers on man/avocado.rst. Please let me know if you are catching something that I'm missing. |
|
@beraldoleal FYI, that are some tests still failing on CI. |
Thanks. it seems ok now! |
|
@clebergnu some issues with cirrus, just restarted and it is working now. |
ana
approved these changes
Dec 10, 2021
richtja
approved these changes
Dec 10, 2021
clebergnu
added a commit
to clebergnu/avocado
that referenced
this pull request
Apr 20, 2022
The "output-check-record" feature was removed from the legacy runner a while ago. This seems to be unused code that could have been removed then, so better be removed now. Reference: avocado-framework#5185 Reference: avocado-framework#3882 Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
added a commit
to clebergnu/avocado
that referenced
this pull request
Apr 21, 2022
The "output-check-record" feature was removed from the legacy runner a while ago. This seems to be unused code that could have been removed then, so better be removed now. Reference: avocado-framework#5185 Reference: avocado-framework#3882 Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
added a commit
to clebergnu/avocado
that referenced
this pull request
Apr 22, 2022
The "output-check-record" feature was removed from the legacy runner a while ago. This seems to be unused code that could have been removed then, so better be removed now. Reference: avocado-framework#5185 Reference: avocado-framework#3882 Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
added a commit
to clebergnu/avocado
that referenced
this pull request
Apr 26, 2022
The "output-check-record" feature was removed from the legacy runner a while ago. This seems to be unused code that could have been removed then, so better be removed now. Reference: avocado-framework#5185 Reference: avocado-framework#3882 Signed-off-by: Cleber Rosa <crosa@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is deprecated and also only works with the legacy runner. In order to implement a new version of this with the new runner architecture would be nice to have a nice "fresh start" and avoid having legacy code. If this makes sense, new tests will be introduced when implementing the new version of this feature, described at #3882.
Signed-off-by: Beraldo Leal bleal@redhat.com