Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the embedded nREPL output to the VSCode output channel #52

Closed
avli opened this issue Jul 24, 2017 · 3 comments · Fixed by #92
Closed

Show the embedded nREPL output to the VSCode output channel #52

avli opened this issue Jul 24, 2017 · 3 comments · Fixed by #92
Labels
question

Comments

@avli
Copy link
Owner

avli commented Jul 24, 2017

We should think if we want to wire the embedded nREPL output with the VSCode output channel. I can see both pros and cons in this approach.

Pros:

  • Some users may found it useful to see the embedded nREPL output in the VSCode output channel. * This also makes the debugging easier.

Cons:

  • Leiningen prints a lot of service information on start which may be confusing and distracting.
@avli avli added the question label Jul 24, 2017
@fasfsfgs fasfsfgs mentioned this issue Jul 24, 2017
Merged
@fasfsfgs
Copy link
Contributor

Is using another output channel hijacks vscode focus?

@caseymarquis
Copy link

Maybe link it to a setting and have it off by default? I got here searching for a way to do just this. A bit of noise at the start of the stream would be well worth it for the full REPL output.

marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Feb 7, 2018
@marcomorain
Add a channel for nREPL output to the Output Window
89da135 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit/close:

If the exit code is not 0, then print the exit code and bring the window
to the front.

Fixes avli#52
@marcomorain
Copy link
Contributor

#92 fixes this 👍

marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Feb 7, 2018
@marcomorain
Add a channel for nREPL output to the Output Window
bf261da 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code
is printed to the nREPL output channel, and the channel is brough to the
front.

Fixes avli#52

Also fixes a bug where the 'Starting nREPL' status message would never
cleaar if the repl failed to start.
marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Feb 7, 2018
@marcomorain
Add a channel for nREPL output to the Output Window
7bc93d8 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code
is printed to the nREPL output channel, and the channel is brough to the
front.

Fixes avli#52

Also fixes a bug where the 'Starting nREPL' status message would never
clear if the repl failed to start.
marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Feb 7, 2018
@marcomorain
Add a channel for nREPL output to the Output Window
7d08f8f 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code
is printed to the nREPL output channel, and the channel is brough to the
front.

Fixes avli#52
Fixed avli#69

Also fixes a bug where the 'Starting nREPL' status message would never
clear if the repl failed to start.
@marcomorain marcomorain mentioned this issue Feb 7, 2018
Merged
marcomorain added a commit to marcomorain/clojureVSCode that referenced this issue Feb 7, 2018
@marcomorain
Add a channel for nREPL output to the Output Window
ffd21a9 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code
is printed to the nREPL output channel, and the channel is brough to the
front.

Fixes avli#52
Fixes avli#53
Fixed avli#69

Also fixes a bug where the 'Starting nREPL' status message would never
clear if the repl failed to start.
@avli avli closed this as completed in #92 Feb 7, 2018
avli pushed a commit that referenced this issue Feb 7, 2018
@marcomorain @avli
Add a channel for nREPL output to the Output Window (#92)
2791b65 
Add a channel to show nREPL output to the user. This channel will be
used for the following:

stdout:

Any stdout messages are sent to the channel.

stderr:

Any stderr messages are sent to the channel, and the channel is brought
to the front to make the user aware.

exit:

If the nREPL closes before be we can load the port, then the exit code
is printed to the nREPL output channel, and the channel is brough to the
front.

Fixes #52
Fixes #53
Fixed #69

Also fixes a bug where the 'Starting nREPL' status message would never
clear if the repl failed to start.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a channel for nREPL output to the Output Window marcomorain/clojureVSCode
4 participants
@marcomorain @avli @caseymarquis @fasfsfgs