Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation errors in "Output" panel instead of "Problems" panel #28

Closed
nigelgilbert opened this issue May 26, 2017 · 3 comments · Fixed by #30
Closed

Compilation errors in "Output" panel instead of "Problems" panel #28

nigelgilbert opened this issue May 26, 2017 · 3 comments · Fixed by #30

Comments

@nigelgilbert
Copy link

nigelgilbert commented May 26, 2017

@avli
How do you feel about putting the eval compilation errors in the "Output" panel, instead of the "Problems" panel?

This is how proto-repl displays compilation errors, and I think it is more convenient, since one doesn't need to click or hotkey to the other panel for feedback.

From a workflow perspective, it just feels clunky to me to have to change panels to see all the Repl output. I don't want to move my cursor, and I don't want to memorize the hotkeys to switch between the Output and Problems panes.

Moreover, from a logical perspective, should the repl compiler errors even fall under "Problem", anyways?
The blank Problems window reads: No problems have been detected in the workspace so far.

The eval compilation may fail due to issues that are not directly related to your workspace, your code, etc. For example, when you eval a function (foo) without first evaluating (defn foo [] ()). Therefore I think that categorically speaking, Output may be a more fitting place for the repl compilation errors.

@nigelgilbert nigelgilbert changed the title Compilation errors in "Output" panel instead of "Problems" Compilation errors in "Output" panel instead of "Problems" Panel May 26, 2017
@nigelgilbert nigelgilbert changed the title Compilation errors in "Output" panel instead of "Problems" Panel Compilation errors in "Output" panel instead of "Problems" panel May 26, 2017
@fasfsfgs
Copy link
Contributor

As an user, I agree with this change as well. That's what I was expecting when first using this extension. I actually used it the first couple weeks without even knowing the 'Problems' tab was used.

If one day we pick up syntax errors on the fly, maybe 'Problems' tab would be a good place to put them.

But for compilation errors, I vote to put those in 'Output' panel.

@avli I can make this change myself if you agree.

@nigelgilbert
Copy link
Author

@fasfsfgs

If one day we pick up syntax errors on the fly, maybe 'Problems' tab would be a good place to put them.

True.

@fasfsfgs
Copy link
Contributor

fasfsfgs commented Jun 7, 2017

I talked to @avli and I'll make this change. Compilation errors are going to the OUTPUT panel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants