Add compatibility with actionpack-page_caching v1.1.0 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actionpack-page_caching v1.1.0 rewrote the internals of performing the page caching to happen inside a different class, so this updates our pseudo-caching to relfect the changes. Should maintain compatibility with actionpack-page_caching <= 1.1.0. Requires ruby 2.0 due to the use of Module#prepend to add our stubs.
|
Looks great, thanks for this! I'll push a new release with this soon. |
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actionpack-page_caching v1.1.0 rewrote the internals of performing the page caching to happen inside a different class (rails/actionpack-page_caching@43dd478), so this updates our fake-caching to reflect the changes.
Should maintain compatibility with actionpack-page_caching <= 1.1.0. I tested locally with Rails 3.2 (page caching built in) and with newer rails with actionpack-page_caching 1.0.2 and 1.1.0 (before and after the problematic change).
Requires ruby 2.0 due to the use of Module#prepend to add our stubs.