Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cluster): add autoupgrade support #59

Merged
merged 4 commits into from
Sep 26, 2024
Merged

feat(cluster): add autoupgrade support #59

merged 4 commits into from
Sep 26, 2024

Conversation

idebeijer
Copy link
Contributor

No description provided.

@idebeijer idebeijer requested a review from virjaina September 17, 2024 10:03
@idebeijer idebeijer self-assigned this Sep 17, 2024
@idebeijer idebeijer marked this pull request as draft September 17, 2024 10:42
@thojkooi
Copy link
Contributor

Fyi you're missing the data source for cluster.

https://github.com/avisi-cloud/terraform-provider-acloud/blob/main/acloud%2Fdata_source_cluster.go

@idebeijer
Copy link
Contributor Author

Fyi you're missing the data source for cluster.

https://github.com/avisi-cloud/terraform-provider-acloud/blob/main/acloud%2Fdata_source_cluster.go

Aha, thanks. So other values like enable_network_encryption (practically all the values prefixed with enable_ in resource_cluster.go) should be added there as well, since they are currently only in resource_cluster.go and not yet in data_source_cluster.go?

@idebeijer
feat: add maintenance schedule data source and resource
4674c35
@idebeijer
feat(cluster): add maintenance schedule id option
2172782
@idebeijer
fix(cluster): handle changes in pointer values
d5b442a 
Add conditional checks using `d.HasChange` for pointer values and handle the change to fix the schema changes to reflect on the keys
djmarkoz
djmarkoz approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@djmarkoz djmarkoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@idebeijer idebeijer marked this pull request as ready for review September 26, 2024 14:35
@idebeijer idebeijer merged commit 57fab79 into main Sep 26, 2024
1 check passed
@idebeijer idebeijer deleted the feat/AME-3348-add-cluster-autoupgrade-support branch September 26, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmarkoz djmarkoz djmarkoz approved these changes

@virjaina virjaina Awaiting requested review from virjaina

Assignees

@idebeijer idebeijer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idebeijer @thojkooi @djmarkoz