Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional datasources #10

Merged
merged 10 commits into from
Nov 13, 2023
Merged

Add additional datasources #10

merged 10 commits into from
Nov 13, 2023

Conversation

thojkooi
Copy link
Contributor

@thojkooi thojkooi commented Oct 25, 2023 •
edited
Loading

  • Add datasource for cloudprovider availability zones.
  • Add datasource for cloud accounts
  • Add datasource for cloud provider node types
  • add datasource for cloud provider regions
  • add datasource for cloud providers
  • add datasource for cluster
  • add availability zone for node pools (optional)
  • made _slug attributes deprecated and replaced those with organisation, environment, or cluster attributes. We have to use both for the time being, for backwards compatability.
  • improved error reporting

@thojkooi thojkooi self-assigned this Oct 25, 2023
@thojkooi thojkooi marked this pull request as draft October 25, 2023 20:56
@thojkooi thojkooi changed the title Draft: add datasource for cloudprovider availability zones Add datasource for cloud provider availability zones Oct 25, 2023
@thojkooi thojkooi added the enhancement New feature or request label Oct 26, 2023
@virjaina virjaina marked this pull request as ready for review October 26, 2023 12:13
@thojkooi
add datasource for cloudprovider availability zones
e5a2f6f 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
add datasource for cloud accounts
3bcb59e 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
add datasource for cloud provider node types
5ddd8f6 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
add datasource cloud provider regions
43e3dc9 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
add datasource for cloud providers
9336bab 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
add datasource for cluster
27e0328 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi thojkooi force-pushed the datasource-cloudprovider-azs branch from 0afc840 to 5d8958f Compare November 12, 2023 18:24
@thojkooi thojkooi requested a review from virjaina November 12, 2023 18:25
@thojkooi
expand documentation descriptions
fb94f66 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi thojkooi force-pushed the datasource-cloudprovider-azs branch from 5d8958f to fb94f66 Compare November 12, 2023 19:32
@thojkooi
add availability zone for node pools
e182ec9 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
remove _slug prefix from attributes for a more uniform ux
c13ec15 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi
refactor error reporting
26dd669 
Signed-off-by: Thomas Kooi <t.j.kooi@avisi.nl>
@thojkooi thojkooi force-pushed the datasource-cloudprovider-azs branch from 0fda2ee to 26dd669 Compare November 13, 2023 11:12
@thojkooi thojkooi changed the title Add datasource for cloud provider availability zones Add additional datasources Nov 13, 2023
@thojkooi thojkooi merged commit 45efcc6 into main Nov 13, 2023
1 check passed
@thojkooi thojkooi deleted the datasource-cloudprovider-azs branch November 13, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djmarkoz djmarkoz djmarkoz approved these changes

@virjaina virjaina Awaiting requested review from virjaina

Assignees

@thojkooi thojkooi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thojkooi @djmarkoz @virjaina