Hide internal properties #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reported here for the exporter: structurizr/export#49 |
|
The appearance in the exported diagrams is fixed once we have a new release of the exporter library, so we can change this PR to only hide this properties in the software homes. Edit: Available in https://github.com/structurizr/export/releases/tag/v1.10.1 |
The Structurizr DSL library introduced element/relationship identifiers as properties recently. Hide those for the site generation since we are not really interested in presenting them to users. Note that at the time of committing they still appear on the generated diagrams, though that has already been addressed upstream in com.structurizr:structurizr-export and will be fixed with a library update once a new version has been released.
jp7677
force-pushed
the
internal-props
branch
from
429c315
to
2953367
Compare
|
The PR has been updated to only address the Software System Homes. |
|
Thanks again, @jp7677! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Structurizr DSL library introduced element/relationship identifiers as properties recently. Hide those for the site generation since we are not really interested in presenting them to users.
This works around the property introduced in structurizr/dsl@0eda61d
The effect without this PR can (currently) be seen here https://avisi-cloud.github.io/structurizr-site-generatr/main/embedding-diagrams-and-images/ and also here https://avisi-cloud.github.io/structurizr-site-generatr/main/internet-banking-system/