Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Home prefix for homepage title #148

Merged
merged 1 commit into from
Feb 28, 2023

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Feb 23, 2023

Do this only when we have a workspace name.

Let me know what you think. In my opinion highlighting that the home page is 'Home' looks overly verbose, esp when bookmarking the page.

Do this only when we have a workspace name.
@dirkgroot
Copy link
Collaborator

Ah, it took me a while to realise that this is about the <title> of the home page 😄. I agree that prefixing it with "Home" is a bit superfluous when there's also a workslace name present.

@dirkgroot dirkgroot merged commit 38dc96b into avisi-cloud:main Feb 28, 2023
@jp7677 jp7677 deleted the home-page-title branch March 5, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants