-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support header branding #128
Conversation
I struggled slightly with the naming, feel free to suggest other names for styles, properties or the css file name. |
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks! I've added some feedback.
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/nl/avisi/structurizr/site/generatr/site/SiteGenerator.kt
Outdated
Show resolved
Hide resolved
Generate a stylesheet containing colors from custom properties from the view configuration. This allows a more customized branding of the header and the menu. Fall back to the current grey if no custom branding is specified.
All issues should be addressed. The remaining question is, do we also want to colorize links? For that we just need to add the following to the generated css.
|
I think it's best to add customization of link colors in a separate PR. This is already a very nice improvement. When it comes to customizing link colors, we'll have to think about whether or not we want to use the primary/secondary colors or maybe a separate one. I'm merging this PR. |
yeah I had similar thoughts, that’s way I hesitated. Thanks! |
Generate a stylesheet containing colors from custom properties from the
view configuration. This allows a more customized branding of the header
and the menu.
Fall back to the current grey if no custom branding is specified.