Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support header branding #128

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Support header branding #128

merged 2 commits into from
Jan 31, 2023

Conversation

jp7677
Copy link
Contributor

@jp7677 jp7677 commented Jan 26, 2023

Generate a stylesheet containing colors from custom properties from the
view configuration. This allows a more customized branding of the header
and the menu.

Fall back to the current grey if no custom branding is specified.

@jp7677
Copy link
Contributor Author

jp7677 commented Jan 26, 2023

I struggled slightly with the naming, feel free to suggest other names for styles, properties or the css file name.

Copy link
Collaborator

@dirkgroot dirkgroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, thanks! I've added some feedback.

Generate a stylesheet containing colors from custom properties from the
view configuration. This allows a more customized branding of the header
and the menu.

Fall back to the current grey if no custom branding is specified.
@jp7677
Copy link
Contributor Author

jp7677 commented Jan 30, 2023

All issues should be addressed. The remaining question is, do we also want to colorize links? For that we just need to add the following to the generated css.

        a {
            color: $primary!important;
        }
        li.is-active a {
            border-bottom-color: $primary!important;
        }
        li a:hover {
            border-bottom-color: $primary!important;
        }

@dirkgroot
Copy link
Collaborator

I think it's best to add customization of link colors in a separate PR. This is already a very nice improvement. When it comes to customizing link colors, we'll have to think about whether or not we want to use the primary/secondary colors or maybe a separate one.

I'm merging this PR.

@dirkgroot dirkgroot merged commit 103c964 into avisi-cloud:main Jan 31, 2023
@jp7677
Copy link
Contributor Author

jp7677 commented Jan 31, 2023

I think it's best to add customization of link colors in a separate PR. This is already a very nice improvement. When it comes to customizing link colors, we'll have to think about whether or not we want to use the primary/secondary colors or maybe a separate one.

yeah I had similar thoughts, that’s way I hesitated. Thanks!

@jp7677 jp7677 deleted the header-colors branch February 21, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants