Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule to limit excessive use of sequential loggers #56

Merged
merged 17 commits into from
Oct 13, 2020
Merged

Add rule to limit excessive use of sequential loggers #56

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5e881f9
PomDependencyVersionRule Implementation.
Oct 2, 2020
5f0a674
Refactor for Plugin and Dependency. Resolve PR Comments.
Oct 2, 2020
b856541
Message change.
Oct 2, 2020
e5f0c62
Add rule to limit excessive use of sequential loggers
MrMcCartney Oct 12, 2020
5ce2f27
Add component count rule
MrMcCartney Oct 12, 2020
49a7816
Add Until Successful variant of component count rule
MrMcCartney Oct 12, 2020
b5f7396
Merge pull request #51 from avioconsulting/Feature/#39-PomDependencyV…
thedevnisarg Oct 13, 2020
a2647cc
Switch LoggerComponent level to use an enum.
MrMcCartney Oct 13, 2020
54a4d3f
Add component count rule
MrMcCartney Oct 12, 2020
ed00b55
Add Until Successful variant of component count rule
MrMcCartney Oct 12, 2020
6d22c38
Add Namespace file with list of common namespaces
MrMcCartney Oct 13, 2020
dc35147
Merge branch 'Feature/#46-component-count-rule' of github.com:aviocon…
MrMcCartney Oct 13, 2020
5959a9c
Merge pull request #57 from avioconsulting/Feature/#46-component-coun…
MrMcCartney Oct 13, 2020
f8358e0
Add rule to limit excessive use of sequential loggers
MrMcCartney Oct 12, 2020
0a677ea
Switch LoggerComponent level to use an enum.
MrMcCartney Oct 13, 2020
a8f3297
Change constructor to use EnumMap rather than Map
MrMcCartney Oct 13, 2020
000788e
Merge branch 'Feature/#44-excessive-loggers' of github.com:avioconsul…
MrMcCartney Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change constructor to use EnumMap rather than Map
  • Loading branch information
@MrMcCartney
MrMcCartney committed Oct 13, 2020
commit a8f32974000424e5ea2178d9fa99fb97ff7f7994
9 changes: 5 additions & 4 deletions ...main/groovy/com/avioconsulting/mule/linter/rule/configuration/ExcessiveLoggersRule.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,16 @@ class ExcessiveLoggersRule extends Rule {
ExcessiveLoggersRule() {}

ExcessiveLoggersRule(Integer excessiveLoggers) {
this([(LoggerComponent.LogLevel.TRACE): excessiveLoggers,
this.ruleId = RULE_ID
this.ruleName = RULE_NAME
this.excessiveLoggers.putAll([(LoggerComponent.LogLevel.TRACE): excessiveLoggers,
(LoggerComponent.LogLevel.DEBUG): excessiveLoggers,
(LoggerComponent.LogLevel.INFO): excessiveLoggers,
(LoggerComponent.LogLevel.WARN): excessiveLoggers,
(LoggerComponent.LogLevel.ERROR): excessiveLoggers]
)
(LoggerComponent.LogLevel.ERROR): excessiveLoggers])
}

ExcessiveLoggersRule(Map<LoggerComponent.LogLevel, Integer> excessiveLoggers) {
ExcessiveLoggersRule(EnumMap<LoggerComponent.LogLevel, Integer> excessiveLoggers) {
this.ruleId = RULE_ID
this.ruleName = RULE_NAME
this.excessiveLoggers.putAll excessiveLoggers
Expand Down
12 changes: 6 additions & 6 deletions .../groovy/com/avioconsulting/mule/linter/rule/configuration/ExcessiveLoggersRuleTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ class ExcessiveLoggersRuleTest extends Specification{

def 'Custom excessive loggers rule fails no flows'() {
given:
Rule rule = new ExcessiveLoggersRule([(LoggerComponent.LogLevel.TRACE): 2,
(LoggerComponent.LogLevel.DEBUG): 3,
(LoggerComponent.LogLevel.INFO): 3,
(LoggerComponent.LogLevel.WARN): 2,
(LoggerComponent.LogLevel.ERROR): 4])

EnumMap<LoggerComponent.LogLevel, Integer> excessiveLoggers = [(LoggerComponent.LogLevel.TRACE): 2,
(LoggerComponent.LogLevel.DEBUG): 3,
(LoggerComponent.LogLevel.INFO): 3,
(LoggerComponent.LogLevel.WARN): 2,
(LoggerComponent.LogLevel.ERROR): 4]
Rule rule = new ExcessiveLoggersRule(excessiveLoggers)

when:
Application app = new Application(testApp.appDir)
Expand Down