Update webmock and http dependencies to latest#85
Open
booty wants to merge 1 commit intoavinashbot:0.8.xfrom
Open
Update webmock and http dependencies to latest#85booty wants to merge 1 commit intoavinashbot:0.8.xfrom
booty wants to merge 1 commit intoavinashbot:0.8.xfrom
Conversation
Author
|
Ah, looks like those updated libraries aren't compatible with Ruby 2.1 -- that's the reason for the Travis failure. If you're committed to supporting Ruby 2.1 then I suppose this is a no-go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this gem in a project that also includes the
twittergem, which uses newer versions of thehttpandwebmockgems.I updated
redd's dependencies with no apparent ill effects.As per CONTRIBUTING.md I've manually tested this change. I'm only using very basic functionality from
reddso it's possible I've missed something, but to the best of my knowledge this should be okay. ¯\_(ツ)_/¯