Fix class name merging for table helper #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `options.reverse_merge` would mistakenly not pick the merged classes with the `tw` helper. This was because `reverse_merge` would continue picking the existing classes. With the change, we pick the new merged classes.
bibstha
commented
Jun 7, 2024
| @@ -1,6 +1,6 @@ | |||
| module Components::TableHelper | |||
| def render_table(caption = nil, **options, &block) | |||
| content_tag :table, options.reverse_merge( | |||
| content_tag :table, options.merge( | |||
There was a problem hiding this comment.
Since if options contains :class already, reverse_merge won't touch it, we need to do merge instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
options.reverse_mergewould mistakenly not pick the merged classes with thetwhelper. This was becausereverse_mergewould continue picking the existing classes.With the change, we pick the new merged classes.