Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deadcode #283

Merged
merged 2 commits into from
May 16, 2024
Merged

Remove the deadcode #283

merged 2 commits into from
May 16, 2024

Conversation

draftcode
Copy link
Contributor

@draftcode draftcode commented May 14, 2024

No description provided.

Copy link
Contributor

aviator-app bot commented May 14, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR was merged using Aviator.

Stack

  1. 👉 Remove the deadcode #283 👈 (this pr)
  2. Do not write messages from UpdatePullRequestState #284
  3. Update libraries #287
  4. Add new sequencer object #288
  5. Make a generic state file read/write mechanism #289

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

Copy link
Contributor

aviator-app bot commented May 14, 2024

FlexReview Summary

Based on the code complexity and the author's expertise score, these are the suggested reviewers:

  • @doratzeng (current review load: 0)

See the list of alternate reviewers in the detailed breakdown below.

Detailed Breakdown Author’s expertise score for the modified files:
  • internal/actions/reorder.go (1.00)
  • internal/gh/client.go (1.00)
  • internal/gh/pullrequest.go (0.17)
  • internal/git/err.go (1.00)
  • internal/meta/refmeta/branch.go (1.00)
  • internal/meta/refmeta/branchstate.go (1.00)
  • internal/utils/sliceutils/sliceutils.go (1.00)
Files Reviewers
internal/git/err.go @doratzeng (score: 0.00, current review load: 0),
@jainankit (score: 0.00, current review load: 3)

† Indicates that the file doesn't need an expert review. (?)

See full breakdown of the reviewers on the Aviator webapp.

@aviator-app aviator-app bot requested a review from doratzeng May 14, 2024 22:49
@aviator-app aviator-app bot changed the base branch from error_not_initialized to master May 16, 2024 17:13
Currently, the repository initialization is checked deeper in the
program. Instead, this change checks that when we open the database.
@draftcode draftcode changed the base branch from master to error_not_initialized May 16, 2024 17:14
@aviator-app aviator-app bot changed the base branch from error_not_initialized to master May 16, 2024 17:15
@aviator-app aviator-app bot merged commit fa0bb12 into master May 16, 2024
4 checks passed
@aviator-app aviator-app bot deleted the remove_unused branch May 16, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants