Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a tcp server to serve received readings to systems like domotics #3

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

llagendijk
Copy link

I have created a TCP server based on EC3K to serve readings to external systems like domoticz (I am about to submit the driver for Domoticz as well). Would you be interested in merging this into EC3K?
I also mad a small modification to the ece3k module to make it work with new osmo-sdr versions.

@llagendijk
Copy link
Author

Just for your information: the driver that reds information from the ec3k-server has been merged into Domoticz

@avian2
Copy link
Owner

avian2 commented Jul 16, 2016

Hi. Thanks for making the pull request. I merged your osmo-sdr fix. I'm not sure about including ec3k-server here. I don't use Domoticz and you did not include any test cases, so I can't test it in a simple way. I'm hesitant to include code in my repo that I can't maintain. Maybe it would be better if you package the server separately (and make it depend on ec3k)?

@llagendijk
Copy link
Author

hi
Thanks for the feedback.

Testing is fairly simple: just start the server and telnet localhost 3001 and you will see the received readings pass by as json strings.
I considered making the server a separate package and was not sure what would be best.
I will setup a separate repository for the server which depend on ec3k as you suggested.

@molobrakos
Copy link
Contributor

molobrakos commented Oct 7, 2016

Maybe you can skip the TCP-server stuff and just keep the output as json on stdout? (adding the TCP-server can easily be done by an external wrapper script in python or using netcat and does not neccessarily have to live in this package).

I am basically trying to do the same by integrating ec3k with Home Assistant (https://home-assistant.io/) and what I currently miss is the scan frequency as a command line argument to the ec3k_recv-script, as well as structured output from the script that can easily be parsed. I am currently using this modified version of ec3k_recv but would like to have the functionality integrated in the ec3k package: https://github.com/molobrakos/ec3kscan/blob/master/ec3k-listen

Edit: Now submitted as https://github.com/avian2/ec3k/pull/4/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants