fix(security): sanitize secrets in debug logs #124
Merged
+298
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debug logging was exposing sensitive environment variables (API keys, tokens, passwords) when KAPSIS_DEBUG was enabled. This fix adds comprehensive secret sanitization: - Add sanitize_secrets() function to logging.sh that masks values of variables containing KEY, TOKEN, SECRET, PASSWORD, CREDENTIALS, AUTH, BEARER, API_KEY, or PRIVATE (case-insensitive) - Update log_cmd(), log_enter(), and log_var() to sanitize output - Fix container command debug log in launch-agent.sh - Add fallback sanitization in entrypoint.sh when logging.sh unavailable - Add 10 new tests for secret sanitization functionality Before: [DEBUG] Container command: podman run -e API_KEY=secret123 ... After: [DEBUG] Container command: podman run -e API_KEY=***MASKED*** ... Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KAPSIS_DEBUGwas enabledsanitize_secrets()function to mask sensitive values in log outputlog_cmd(),log_enter(), andlog_var()to automatically sanitize their outputChanges
scripts/lib/logging.shscripts/launch-agent.shscripts/entrypoint.shtests/test-logging.shPatterns Masked
Variables containing these keywords (case-insensitive) are now masked:
KEY,TOKEN,SECRET,PASSWORD,CREDENTIALSAUTH,BEARER,API_KEY,PRIVATEExample
Before:
After:
Test plan
sanitize_secrets()correctly masks sensitive patternsKAPSIS_DEBUG=1to verify no secrets leak🤖 Generated with Claude Code