Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure builds don't timeout due to gcp client pooling #87

Merged
merged 4 commits into from
Apr 13, 2023

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Apr 13, 2023

Describe your changes

Often happen the when building large GPU images on cloud build we hit GCPs client pooling timeout, and the cloud build timeout itself does not affect this setting.

This change ensures the config cloud build timeout, also applies to the pooling

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 25.00% and project coverage change: -0.02 ⚠️

Comparison is base (8b9d240) 74.16% compared to head (c963c49) 74.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   74.16%   74.15%   -0.02%     
==========================================
  Files          57       57              
  Lines        2795     2797       +2     
==========================================
+ Hits         2073     2074       +1     
- Misses        722      723       +1     
Impacted Files Coverage Δ
src/wanna/core/services/docker.py 64.62% <25.00%> (-0.14%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsilva jsilva requested a review from racinmat April 13, 2023 13:57
@jsilva jsilva marked this pull request as ready for review April 13, 2023 13:57
Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00069-2133207980-((thumbs up)), ((masterpiece)), (best quality), (monochrome), businesses suit, (colorful hair), office, falling paper

@jsilva jsilva merged commit 83a9c3c into master Apr 13, 2023
@jsilva jsilva deleted the joao/cloud-build-pooling-timeout branch April 13, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants