Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: MLOPS-286 - env option to disable remote GCP validation #82

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Apr 3, 2023

Describe your changes

wanna-ml when loads the yaml runs validations against GCP resources, this is good however for fast iteration it delays the wanna cli runs and this can be frustrating.

This PR provides the option to disable those remote validations that connect GCP.

Issue ticket number and link

MLOPS-286

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 48.14% and project coverage change: +0.03 🎉

Comparison is base (029a53c) 74.03% compared to head (ef4ae27) 74.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
+ Coverage   74.03%   74.07%   +0.03%     
==========================================
  Files          57       57              
  Lines        2777     2785       +8     
==========================================
+ Hits         2056     2063       +7     
- Misses        721      722       +1     
Impacted Files Coverage Δ
src/wanna/core/utils/validators.py 67.41% <12.50%> (-0.77%) ⬇️
src/wanna/core/utils/env.py 100.00% <100.00%> (ø)
src/wanna/core/utils/gcp.py 56.81% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jsilva jsilva merged commit f8e0a0b into master Apr 3, 2023
@jsilva jsilva deleted the joao/mlops-286 branch April 3, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants