Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for jinja2-time expressions in pipeline params #80

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Mar 2, 2023

Describe your changes

feat: add support for jinja2-time expressions in pipeline params for flexible dates at pipeline trigger time

Due to python-poetry/poetry#7611 had to fix poetry version to 1.3.2

Issue ticket number and link

MLOPS-260

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: -0.04 ⚠️

Comparison is base (d767244) 74.15% compared to head (49a529e) 74.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   74.15%   74.11%   -0.04%     
==========================================
  Files          57       57              
  Lines        2751     2774      +23     
==========================================
+ Hits         2040     2056      +16     
- Misses        711      718       +7     
Impacted Files Coverage Δ
src/wanna/core/services/base.py 54.08% <0.00%> (ø)
src/wanna/core/utils/gcp.py 56.81% <ø> (ø)
.../wanna/components/kubeflow/upload_model_version.py 9.52% <14.28%> (-0.74%) ⬇️
...anna/components/kubeflow/get_or_create_endpoint.py 13.79% <33.33%> (-0.50%) ⬇️
src/wanna/core/services/pipeline.py 91.42% <40.00%> (+0.06%) ⬆️
src/wanna/core/services/jobs.py 73.68% <75.00%> (-0.87%) ⬇️
src/wanna/cli/plugins/common_options.py 100.00% <100.00%> (ø)
src/wanna/core/deployment/models.py 98.01% <100.00%> (ø)
src/wanna/core/deployment/vertex_pipelines.py 56.00% <100.00%> (+0.44%) ⬆️
src/wanna/core/models/training_custom_job.py 95.95% <100.00%> (+0.04%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but mypy seems to be complaining.

Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00032-1998412851-((thumbs up)), ((masterpiece)), (best quality), sharp look

@jsilva jsilva merged commit 94e4a1f into master Mar 24, 2023
@jsilva jsilva deleted the joao/mlops-260 branch March 24, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants