Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: run jobs with overriding command and args #78

Merged
merged 2 commits into from
Jan 25, 2023
Merged

feat: run jobs with overriding command and args #78

merged 2 commits into from
Jan 25, 2023

Conversation

jsilva
Copy link
Collaborator

@jsilva jsilva commented Jan 25, 2023

Describe your changes

Update jobs runner to allow overriding of command and args

Issue ticket number and link

MLOPS-242

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • If it is a core feature, I have added thorough tests.

racinmat
racinmat approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@racinmat racinmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
00143-2235453807-(thumbs up), oil paint, ((masterpiece)), (best quality)(sharp look), (Jojo pose), ((business suit)), (adult), (colorful eyes), (

@jsilva jsilva merged commit fa0fa3e into master Jan 25, 2023
@jsilva jsilva deleted the joao/job-args-override branch January 25, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obonovai obonovai obonovai approved these changes

@illethrias illethrias illethrias approved these changes

@racinmat racinmat racinmat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsilva @racinmat @illethrias @obonovai